ange/godot
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix inspector Array/Dictionary slot button leaks

Browse Source 
(cherry picked from commit 21bc715f32477afd4e6664ea4522c96db9b0165f)
This commit is contained in:
SynthBioTech authored and Thaddeus Crews committed 2026-07-30 11:29:02 -05:00
1 parent bc30f475e2
commit e9ea372b8a
1 file changed
+5
Download Patch File Download Diff File Expand all files Collapse all files
editor/inspector/editor_properties_array_dict.cpp
+5
View File
@@ -342,6 +342,7 @@ void EditorPropertyArray::_create_new_property_slot() {
reorder_button->connect(SNAME("button_down"), callable_mp(this, &EditorPropertyArray::_reorder_button_down).bind(idx));
hbox->add_child(prop);
prop->add_inline_control(reorder_button, INLINE_CONTROL_LEFT);
bool is_untyped_array = object->get_array().get_type() == Variant::ARRAY && subtype == Variant::NIL;
@@ -354,6 +355,7 @@ void EditorPropertyArray::_create_new_property_slot() {
edit_btn->set_disabled(is_read_only());
edit_btn->set_theme_type_variation(SNAME("EditorInspectorFlatButton"));
edit_btn->connect(SceneStringName(pressed), callable_mp(this, &EditorPropertyArray::_change_type).bind(edit_btn, idx));
prop->add_inline_control(edit_btn, INLINE_CONTROL_RIGHT);
} else {
remove_btn = memnew(Button);
remove_btn->set_accessibility_name(TTRC("Remove"));
@@ -361,6 +363,7 @@ void EditorPropertyArray::_create_new_property_slot() {
remove_btn->set_disabled(is_read_only());
remove_btn->set_theme_type_variation(SNAME("EditorInspectorFlatButton"));
remove_btn->connect(SceneStringName(pressed), callable_mp(this, &EditorPropertyArray::_remove_pressed).bind(idx));
prop->add_inline_control(remove_btn, INLINE_CONTROL_RIGHT);
}
property_vbox->add_child(hbox);
@@ -1132,6 +1135,7 @@ void EditorPropertyDictionary::_create_new_property_slot(int p_idx) {
edit_btn->set_disabled(is_read_only());
edit_btn->set_theme_type_variation(SNAME("EditorInspectorFlatButton"));
edit_btn->connect(SceneStringName(pressed), callable_mp(this, &EditorPropertyDictionary::_change_type).bind(edit_btn, slots.size()));
prop->add_inline_control(edit_btn, INLINE_CONTROL_RIGHT);
} else if (p_idx >= 0) {
remove_btn = memnew(Button);
remove_btn->set_accessibility_name(TTRC("Remove"));
@@ -1139,6 +1143,7 @@ void EditorPropertyDictionary::_create_new_property_slot(int p_idx) {
remove_btn->set_disabled(is_read_only());
remove_btn->set_theme_type_variation(SNAME("EditorInspectorFlatButton"));
remove_btn->connect(SceneStringName(pressed), callable_mp(this, &EditorPropertyDictionary::_remove_pressed).bind(slots.size()));
prop->add_inline_control(remove_btn, INLINE_CONTROL_RIGHT);
}
if (add_panel) {