ange/godot
1
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Various fixes detected using PVS-Studio static analyzer.

Browse Source 
- Add FIXME tags comments to some unfixed potential bugs
- Remove some checks (always false: unsigned never < 0)
- Fix some if statements based on reviews.
- Bunch of missing `else` statements
This commit is contained in:
Thaer Razeq authored and REBELLIOUSX\Rebel_X committed 2017-02-28 07:52:02 -06:00
1 parent 0f8c6dd382
commit f50488a361
32 files changed
+41 -39
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

modules/visual_script/visual_script_builtin_funcs.cpp
+1 -1
View File
@@ -329,7 +329,7 @@ PropertyInfo VisualScriptBuiltinFunc::get_input_value_port_info(int p_idx) const
case LOGIC_CLAMP: {
if (p_idx==0)
return PropertyInfo(Variant::REAL,"a");
else if (p_idx==0)
else if (p_idx==0) // is it ok to test p_idx == 0 twice?
return PropertyInfo(Variant::REAL,"min");
else
return PropertyInfo(Variant::REAL,"max");