From 27b3ee0755b100e62e53feac18eb1970522db159 Mon Sep 17 00:00:00 2001 From: AtomicAntt Date: Thu, 7 May 2026 11:02:23 -0700 Subject: [PATCH] Rename various signal parameters called 'name' --- doc/classes/AnimationLibrary.xml | 18 +++++++++--------- doc/classes/AnimationNode.xml | 2 +- doc/classes/AnimationPlayer.xml | 2 +- doc/classes/XRPositionalTracker.xml | 8 ++++---- scene/animation/animation_player.cpp | 2 +- scene/animation/animation_tree.cpp | 2 +- scene/resources/animation_library.cpp | 8 ++++---- servers/xr/xr_positional_tracker.cpp | 8 ++++---- 8 files changed, 25 insertions(+), 25 deletions(-) diff --git a/doc/classes/AnimationLibrary.xml b/doc/classes/AnimationLibrary.xml index bfd3e83705..275172c8c8 100644 --- a/doc/classes/AnimationLibrary.xml +++ b/doc/classes/AnimationLibrary.xml @@ -62,29 +62,29 @@ - + - Emitted when an [Animation] is added, under the key [param name]. + Emitted when an [Animation] is added, under the key [param anim_name]. - + - Emitted when there's a change in one of the animations, e.g. tracks are added, moved or have changed paths. [param name] is the key of the animation that was changed. + Emitted when there's a change in one of the animations, e.g. tracks are added, moved or have changed paths. [param anim_name] is the key of the animation that was changed. See also [signal Resource.changed], which this acts as a relay for. - + - Emitted when an [Animation] stored with the key [param name] is removed. + Emitted when an [Animation] stored with the key [param anim_name] is removed. - - + + - Emitted when the key for an [Animation] is changed, from [param name] to [param to_name]. + Emitted when the key for an [Animation] is changed, from [param old_name] to [param new_name]. diff --git a/doc/classes/AnimationNode.xml b/doc/classes/AnimationNode.xml index 332c8ba377..a953854b3f 100644 --- a/doc/classes/AnimationNode.xml +++ b/doc/classes/AnimationNode.xml @@ -212,7 +212,7 @@ - + Emitted by nodes that inherit from this class and that have an internal tree when one of their animation nodes removes. The animation nodes that emit this signal are [AnimationNodeBlendSpace1D], [AnimationNodeBlendSpace2D], [AnimationNodeStateMachine], and [AnimationNodeBlendTree]. diff --git a/doc/classes/AnimationPlayer.xml b/doc/classes/AnimationPlayer.xml index d02c3f8f27..5e8bed83d7 100644 --- a/doc/classes/AnimationPlayer.xml +++ b/doc/classes/AnimationPlayer.xml @@ -343,7 +343,7 @@ - + Emitted when [member current_animation] changes. diff --git a/doc/classes/XRPositionalTracker.xml b/doc/classes/XRPositionalTracker.xml index 78a8fad5b7..17a0c2243d 100644 --- a/doc/classes/XRPositionalTracker.xml +++ b/doc/classes/XRPositionalTracker.xml @@ -70,26 +70,26 @@ - + Emitted when a button on this tracker is pressed. Note that many XR runtimes allow other inputs to be mapped to buttons. - + Emitted when a button on this tracker is released. - + Emitted when a trigger or similar input on this tracker changes value. - + Emitted when a thumbstick or thumbpad on this tracker moves. diff --git a/scene/animation/animation_player.cpp b/scene/animation/animation_player.cpp index 435a86124f..ad0e1919da 100644 --- a/scene/animation/animation_player.cpp +++ b/scene/animation/animation_player.cpp @@ -1067,7 +1067,7 @@ void AnimationPlayer::_bind_methods() { ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "speed_scale", PROPERTY_HINT_RANGE, "-4,4,0.001,or_less,or_greater"), "set_speed_scale", "get_speed_scale"); ADD_PROPERTY(PropertyInfo(Variant::BOOL, "movie_quit_on_finish"), "set_movie_quit_on_finish_enabled", "is_movie_quit_on_finish_enabled"); - ADD_SIGNAL(MethodInfo("current_animation_changed", PropertyInfo(Variant::STRING_NAME, "name"))); + ADD_SIGNAL(MethodInfo("current_animation_changed", PropertyInfo(Variant::STRING_NAME, "anim_name"))); ADD_SIGNAL(MethodInfo("animation_changed", PropertyInfo(Variant::STRING_NAME, "old_name"), PropertyInfo(Variant::STRING_NAME, "new_name"))); } diff --git a/scene/animation/animation_tree.cpp b/scene/animation/animation_tree.cpp index 92daabd9a3..41ff9965d2 100644 --- a/scene/animation/animation_tree.cpp +++ b/scene/animation/animation_tree.cpp @@ -576,7 +576,7 @@ void AnimationNode::_bind_methods() { ADD_SIGNAL(MethodInfo("tree_changed")); ADD_SIGNAL(MethodInfo("node_updated", PropertyInfo(Variant::INT, "object_id"))); ADD_SIGNAL(MethodInfo("animation_node_renamed", PropertyInfo(Variant::INT, "object_id"), PropertyInfo(Variant::STRING, "old_name"), PropertyInfo(Variant::STRING, "new_name"))); - ADD_SIGNAL(MethodInfo("animation_node_removed", PropertyInfo(Variant::INT, "object_id"), PropertyInfo(Variant::STRING, "name"))); + ADD_SIGNAL(MethodInfo("animation_node_removed", PropertyInfo(Variant::INT, "object_id"), PropertyInfo(Variant::STRING, "node_name"))); BIND_ENUM_CONSTANT(FILTER_IGNORE); BIND_ENUM_CONSTANT(FILTER_PASS); diff --git a/scene/resources/animation_library.cpp b/scene/resources/animation_library.cpp index fd7cdf78f6..28208fb537 100644 --- a/scene/resources/animation_library.cpp +++ b/scene/resources/animation_library.cpp @@ -172,10 +172,10 @@ void AnimationLibrary::_bind_methods() { ADD_PROPERTY(PropertyInfo(Variant::DICTIONARY, "_data", PROPERTY_HINT_NONE, "", PROPERTY_USAGE_NO_EDITOR | PROPERTY_USAGE_INTERNAL), "_set_data", "_get_data"); - ADD_SIGNAL(MethodInfo("animation_added", PropertyInfo(Variant::STRING_NAME, "name"))); - ADD_SIGNAL(MethodInfo("animation_removed", PropertyInfo(Variant::STRING_NAME, "name"))); - ADD_SIGNAL(MethodInfo("animation_renamed", PropertyInfo(Variant::STRING_NAME, "name"), PropertyInfo(Variant::STRING_NAME, "to_name"))); - ADD_SIGNAL(MethodInfo("animation_changed", PropertyInfo(Variant::STRING_NAME, "name"))); + ADD_SIGNAL(MethodInfo("animation_added", PropertyInfo(Variant::STRING_NAME, "anim_name"))); + ADD_SIGNAL(MethodInfo("animation_removed", PropertyInfo(Variant::STRING_NAME, "anim_name"))); + ADD_SIGNAL(MethodInfo("animation_renamed", PropertyInfo(Variant::STRING_NAME, "old_name"), PropertyInfo(Variant::STRING_NAME, "new_name"))); + ADD_SIGNAL(MethodInfo("animation_changed", PropertyInfo(Variant::STRING_NAME, "anim_name"))); } AnimationLibrary::AnimationLibrary() { } diff --git a/servers/xr/xr_positional_tracker.cpp b/servers/xr/xr_positional_tracker.cpp index 7e1ee27592..eecbf03ec7 100644 --- a/servers/xr/xr_positional_tracker.cpp +++ b/servers/xr/xr_positional_tracker.cpp @@ -56,10 +56,10 @@ void XRPositionalTracker::_bind_methods() { ClassDB::bind_method(D_METHOD("get_input", "name"), &XRPositionalTracker::get_input); ClassDB::bind_method(D_METHOD("set_input", "name", "value"), &XRPositionalTracker::set_input); - ADD_SIGNAL(MethodInfo("button_pressed", PropertyInfo(Variant::STRING, "name"))); - ADD_SIGNAL(MethodInfo("button_released", PropertyInfo(Variant::STRING, "name"))); - ADD_SIGNAL(MethodInfo("input_float_changed", PropertyInfo(Variant::STRING, "name"), PropertyInfo(Variant::FLOAT, "value"))); - ADD_SIGNAL(MethodInfo("input_vector2_changed", PropertyInfo(Variant::STRING, "name"), PropertyInfo(Variant::VECTOR2, "vector"))); + ADD_SIGNAL(MethodInfo("button_pressed", PropertyInfo(Variant::STRING, "action_name"))); + ADD_SIGNAL(MethodInfo("button_released", PropertyInfo(Variant::STRING, "action_name"))); + ADD_SIGNAL(MethodInfo("input_float_changed", PropertyInfo(Variant::STRING, "action_name"), PropertyInfo(Variant::FLOAT, "value"))); + ADD_SIGNAL(MethodInfo("input_vector2_changed", PropertyInfo(Variant::STRING, "action_name"), PropertyInfo(Variant::VECTOR2, "vector"))); ADD_SIGNAL(MethodInfo("profile_changed", PropertyInfo(Variant::STRING, "role"))); }